fix: adding length validation on deserialization #19415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzeszutko
changed the title
mrzeszutko
force-pushed
the
feature/bitvector-semantic-validation
branch
from
c73a4ea to
b6cc9cb
Compare
PhilWindle
changed the title
PhilWindle
reviewed
Jan 9, 2026
Collaborator
PhilWindle
left a comment
PhilWindle
left a comment
There was a problem hiding this comment.
Looks good. Just one thing we need to check.
| const reader = BufferReader.asReader(buffer); | ||
| return new StatusMessage( | ||
| reader.readString(), // compressedComponentsVersion | ||
| reader.readString(MAX_VERSION_STRING_LENGTH), // compressedComponentsVersion |
Collaborator
There was a problem hiding this comment.
Can we just check this? This version isn't a semver (i.e. 1.2.3-alpha.123). It's our compressed components version which incorporates a number of items. Can you verify that MAX_VERSION_STRING_LENGTH is sufficient for this?
Collaborator
There was a problem hiding this comment.
Here is an example:
p2p:7:libp2p_service:libp2p_service Started libp2p service with protocol version 00-31337-00000000-0-14d6d44e-01eff751
Collaborator
There was a problem hiding this comment.
I think we should be fine as MAX_VERSION_STRING_LENGTH is 64, but would like to check.
Contributor
Author
There was a problem hiding this comment.
@PhilWindle 64 seems to be enough for MAX_VERSION_STRING_LENGTH looking at how the version string is created:
return [
'00',
versions.l1ChainId,
versions.l1RollupAddress.toString().slice(2, 10),
versions.rollupVersion,
versions.l2ProtocolContractsHash.toString().slice(2, 10),
versions.l2CircuitsVkTreeRoot.toString().slice(2, 10),
].join('-');
64 seems to be 2x as long as expected length
PhilWindle
approved these changes
Jan 12, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AztecBot
force-pushed
the
feature/bitvector-semantic-validation
branch
from
4e795d8 to
3e72988
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
mrzeszutko
force-pushed
the
feature/bitvector-semantic-validation
branch
from
3e72988 to
11f73b1
Compare
mrzeszutko
force-pushed
the
feature/bitvector-semantic-validation
branch
from
11f73b1 to
994b779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add semantic validation to P2P message deserialization to reject protocol-violating array/string lengths. This prevents DoS attacks via maliciously crafted messages that specify enormous sizes, which could cause memory exhaustion before the buffer range check catches the issue.
Changes
Foundation Layer
maxSizeparameter toreadVector(),readBuffer(), andreadString()methods. This is a non-breaking change - all 161+ existing calls continue to work unchanged.Constants Organization
stdlib/deserialization: New module with shared constants:
MAX_TXS_PER_BLOCK= 2 ** 16 (65536)MAX_COMMITTEE_SIZE = 2,048(theoretical max from bitmap design: 256 bytes × 8 bits)MAX_BLOCKS_PER_CHECKPOINT = 72MAX_TX_EFFECTS_PER_BODY = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOBMAX_BLOCK_HASH_STRING_LENGTH = 128p2p/reqresp/constants: P2P-specific constants:
MAX_VERSION_STRING_LENGTH = 64MAX_BLOCK_HASH_STRING_LENGTH = 128MAX_TXS_PER_BLOCKfrom stdlibBounds Checking Added To
BlockProposal.fromBufferSignedTxs.fromBufferCheckpointProposal.fromBufferCheckpoint.fromBufferPublishedCheckpoint.fromBufferBody.fromBufferCheckpointedL2Block.fromBufferPublishedL2Block.fromBufferdeserializeValidateBlockResultStatusMessage.fromBufferBitVector.fromBufferTests
BufferReadermaxSize bounds checkingBitVectorbounds validationFixes A-273